Don not use the present perfect (I have done) when you talk about a finished time (for example, yesterday / twenty minutes ago / in 1988 / when I was a child). Use a past tense:
- The weather was nice yesterday. (not “has been nice”)
- They arrived twenty minutes ago. (not “have arrived”)
- I ate a lot of sweets when I was a child. (not “have eaten”)
Did you see the news on television last night? (not “Have you seen”)
No, I went to bed early. (not “have gone”)
Use a past tense to ask When…? or What time…?
- When did she arrive? (not “has she arrived”)
- What time did you finish work?
- Jeff has lost his key. He can’t get into the house.
Here, we are not thinking of the past action. We are thinking of the present result of the action: Jeff doesn’t have his key now.
- Jeff lost his key yesterday. He couldn’t get into the house.
Here, we are thinking of the action in the past. We don’t know from this sentence whether Jeff has his key now.
Compare present perfect and past:
- We’ve done a lot of work today.
We use the present perfect for a period of time that continues from the past until now. For example, today, this week, since 1988.
- We did a lot of work yesterday.
We use the past simple for a finished time in the past. For example, yesterday, last week, from 2010 to 2015.
- It hasn’t rained this week.
- It didn’t rain last week.
- Have you seen Michael this morning? (it is still morning)
- Did you see Michael this morning? (it is now afternoon or evening)
- Have you seen Jane recently?
- Did you see Jane on Saturday?
- I don’t know where Robert. I haven’t seen him. (= I haven’t seen him recently)
Was Robert at the party on Sunday?
I don’t think so. I didn’t see him.
- I’ve been waiting for an hour. (I am still waiting now)
- I waited (or was waiting) for an hour. (I am no longer waiting)
- Lisa lives in New York. She has lived there for three years.
- Susan lived in Toronto for five years. Now she lives in London.
- I have never played golf. (in my life)
- I didn’t play golf when I was on holiday last summer.
The present perfect always has a connection with now. See Present Perfect – Part 1, Part 2, Present Perfect Continuous, Present Perfect Continuous and Simple, How long have you (been)…? and When…? and How long…? For and Since.